-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add AI acknowledgement checkbox and welcome comment #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RDaxini
wants to merge
10
commits into
pvlib:main
Choose a base branch
from
RDaxini:prtemplate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−0
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eb0f127
Update PULL_REQUEST_TEMPLATE.md
RDaxini 6554dfb
shorten pr checkbox
RDaxini 490942c
add welcome for pr and issue
RDaxini f3b1c03
misc
RDaxini ebf674f
Merge remote-tracking branch 'upstream/main' into prtemplate
RDaxini 360b6e5
Update v0.13.2.rst
RDaxini 52e6260
remove issue +tag co-authors
RDaxini 3de7a76
Merge remote-tracking branch 'upstream/main' into prtemplate
RDaxini cbeb170
transfer whatsnew entry
RDaxini ae12b8a
Merge remote-tracking branch 'upstream/main' into prtemplate
RDaxini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: Welcome First-Time Contributor | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: opened | ||
|
|
||
| jobs: | ||
| welcome: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: write | ||
| steps: | ||
| - uses: plbstl/first-contribution@v4 | ||
| with: | ||
| pr-opened-msg: | | ||
| ### Hey @{fc-author}! :tada: | ||
|
|
||
| Thanks for opening your first pull request! We appreciate your | ||
| contribution. Please ensure you have reviewed and understood the | ||
| [contributing guidelines](https://pvlib-python.readthedocs.io/en/latest/contributing/index.html). | ||
|
|
||
| If AI is used for any portion of this PR, you must vet the content | ||
| for technical accuracy and compatibility with the contributing | ||
| guidelines. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What aspects of "compatibility" are we envisioning here? Just the usual numpydoc formatting, tests, etc, or something more AI-specific like copyright and licensing? We don't (currently) have anything AI-specific in our contributing guide.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this is not really clear. It was more of a hand-wavy statement. I think the ultimate solution would be to document something in the guidelines and reference that. So, how about I just remove the "and compatibility..." part for now? Once we have something official in the guidelines, we can more specifically reference that here.