Skip to content

Change get_pvgis_tmy coerce_year default to 1990 #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Jun 5, 2025

  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR changes the default value of coerce_year from None to 1990 in the pvlib.iotools.get_pvgis_tmy function. This is a breaking change and is not deprecated since it will be part of the same release as other breaking changes to the function that cannot be deprecated (see #2470).

The desire for this change is that the get_pvgis_tmy function is commonly used for introductory tutorials, where beginners often waste a lot of time on getting "strange" plots because the TMY indexes span +10 years.

@AdamRJensen AdamRJensen added this to the v0.12.1 milestone Jun 5, 2025
@AdamRJensen AdamRJensen added the io label Jun 5, 2025
@AdamRJensen AdamRJensen added the remote-data triggers --remote-data pytests label Jun 5, 2025
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 5, 2025
@AdamRJensen AdamRJensen marked this pull request as ready for review June 5, 2025 22:37
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 5, 2025
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 5, 2025
Co-authored-by: Kevin Anderson <[email protected]>
@kandersolar kandersolar merged commit 4ef2813 into pvlib:main Jun 6, 2025
30 checks passed
@AdamRJensen AdamRJensen deleted the get_pvgis_tmy_coerce_year_default branch June 6, 2025 21:08
@kandersolar kandersolar modified the milestones: v0.12.1, v0.13.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants