Fix some broken links #1957
Merged
Fix some broken links #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamRJensen
reviewed
Jan 30, 2024
AdamRJensen
approved these changes
Jan 30, 2024
pvlib/iotools/srml.py
Outdated
Comment on lines
292
to
293
| `http://solardata.uoregon.edu/StationIDCodes.html | ||
| <http://solardata.uoregon.edu/StationIDCodes.html>`_ |
There was a problem hiding this comment.
Suggested change
| `http://solardata.uoregon.edu/StationIDCodes.html | |
| <http://solardata.uoregon.edu/StationIDCodes.html>`_ | |
| `http://solardata.uoregon.edu/StationIDCodes.html`_ |
Just to follow the same formatting as previous
There was a problem hiding this comment.
I don't think this formatting is what we want. It renders like this:
If we just want the raw URL to be displayed as the link text, then no markup is needed. See the iam.ashrae docstring for example.
Co-authored-by: Adam R. Jensen <[email protected]>
kandersolar
approved these changes
Feb 1, 2024
|
Thanks @cwhanse and @echedey-ls! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.More link repairs in response to #1794