Add include and exclude to publish config #972
Conversation
| @@ -94,13 +94,17 @@ type PublishConfig = | |||
| { version :: Version | |||
| , license :: License | |||
| , location :: Maybe Location | |||
| , include :: Maybe (Array FilePath) | |||
| , exclude :: Maybe (Array FilePath) | |||
There was a problem hiding this comment.
These are really globs, right? Should we newtype and sanitize this the way it’s done in the registry?
There was a problem hiding this comment.
This part of the PR is about specifying things in the config file. I am not sure we'd want to parse/validate things here already, all this stuff is mostly about reading things in.
Even in the registry the sanitizePath function that you link is only used at glob-matching time, inside Registry.Foreign.FastGlob.match'.
We use that same function to match globs here, so if I understand correctly we're already getting the sanitization for free.
There was a problem hiding this comment.
Oh so it's impossible to add sources from a sibling project in the same project? I guess we can always relax that if the need ever arises.
There was a problem hiding this comment.
It should be impossible to add sources from a sibling project as far as the registry (publishing) is concerned, though I suppose it’s fine for Spago
There was a problem hiding this comment.
I don't think it should be fine for Spago either, the proper mechanism for adding sibling projects is through a package dependency.
This change adds config keys
includefor specifying an array of globs matching files that shall be published in addition to the default (anything matching in/src/**.purs)excludefor finally specifying an array of globs to remove from the union of what's matched by the default andincludeIt's the first step to supporting this in the registry. Once this is merged, we'll add support and validation for this in the
registry-devrepo and then finally finish with a PR tospago/app.See #967 for discussion leading to this change.