Fix CompilerError
decoding in 0.13.x series of purs
#635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #255, @thomashoneyman noticed some log lines reporting unknown compiler errors, like
It turns out that starting in 0.14.0, compiler errors were switched to being reported to stdout, whereas they used to be in stderr: https://github.com/purescript/purescript/releases/tag/v0.14.0
This PR changes
CompilerArgs
to take aVersion
, so we can check that we can get properVersion
Ord
and check compiler versions before deciding where to try to parse the compiler errors from, and propagates the changes needed to make that typecheck. It also adds tests to catch this case.