[NLU-3830] SPIKE: Language agnostic entity support #136
Conversation
samhickey25
requested review from
kevinwalshgen,
colm-dillon,
andrew-gradinari,
Conor-Keaney,
KanchanKumar12,
BobbyMartins5 and
CiaraCrowe
| ] | ||
| }, | ||
| { | ||
| "Input": "1,000,000", |
There was a problem hiding this comment.
I think we need to spell out what we expect when we get 1.000.00,00 instead
There was a problem hiding this comment.
yeah I think I'm going to add another test file for these other formats. I can't have them both in the one file because once the recogniser is initialised it stuck using that format
| @@ -0,0 +1,122 @@ | |||
| [ | |||
There was a problem hiding this comment.
Similar here, the expected output on: 192.168.0.1. I don't expect it to work, just to know the limitations of it.
|
|
||
| class BaseMinimalDateParser(BaseDateParser): | ||
|
|
||
| def __init__(self, config): |
There was a problem hiding this comment.
Do we need these init's if we are just calling the super?
There was a problem hiding this comment.
I thought about it and decided to leave this here for consistency. Wanted to be clear that the BaseMinimal classes are being used
| self._utility_configuration = config.utility_configuration | ||
| self._check_both_before_after = MinimalDateTime.CheckBothBeforeAfter | ||
|
|
||
| def __normalize(self, source: str) -> str: |
There was a problem hiding this comment.
Where is this used?
There was a problem hiding this comment.
it's not actually, copied it from somewhere and forgot to remove it
No description provided.