Skip to content

Install required packages and locales before installation #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Install required packages and locales before installation #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plans/subplans/install.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@
)
}

run_task('peadm::preinstall', $all_targets)

if $pe_installer_source {
$pe_tarball_name = $pe_installer_source.split('/')[-1]
$pe_tarball_source = $pe_installer_source
Expand Down
8 changes: 8 additions & 0 deletions tasks/preinstall.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"puppet_task_version": 1,
"supports_noop": false,
"description": "Installs required packages, and configuration required before PE can be installed.",
"implementations": [
{"name": "preinstall.sh"}
]
}
21 changes: 21 additions & 0 deletions tasks/preinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/bin/sh

# Setup required packages
packages="curl gnupg"
Copy link
Collaborator

@bastelfreak bastelfreak Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be awesome if the installer itself would already handle this. Then it will work for people that directly use the installer.

Copy link
Author

@zaben903 zaben903 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl and gnupg are used by peadm when downloading the installer package not by puppet-enterprise-installer.

Generating en_US.UTF-8 might be more appropriate within the PuppetDB installation.

if command -v apt-get >/dev/null 2>&1; then
apt-get update
apt-get install -y ${packages} locales

# Generate en_US.UTF-8 locale for PuppetDB
if ! locale-gen en_US.UTF-8; then
echo "Failed to generate locale en_US.UTF-8" >&2
exit 1
fi
elif command -v yum >/dev/null 2>&1; then
yum install -y ${packages} glibc-langpack-en
else
echo "No supported package manager found (apt-get or yum required)." >&2
exit 1
fi

exit 0
Loading