Revert "(CONT-785) Rubocop Manual Fix 5 - RSpec/NoExpectationExample"

This reverts commit f4f53c3.

Author: david22swan

.rubocop_todo.yml

@@ -61,6 +61,20 @@ RSpec/ExampleLength:
 RSpec/NestedGroups:
   Max: 4
 
+# Offense count: 18
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/acceptance/chain_key_spec.rb'
+    - 'spec/acceptance/content_spec.rb'
+    - 'spec/acceptance/destkeypass_spec.rb'
+    - 'spec/acceptance/keystore_spec.rb'
+    - 'spec/acceptance/pkcs12_spec.rb'
+    - 'spec/acceptance/private_key_spec.rb'
+    - 'spec/acceptance/truststore_spec.rb'
+    - 'spec/unit/puppet/type/java_ks_spec.rb'
+
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: .

spec/acceptance/chain_key_spec.rb

@@ -7,7 +7,7 @@
   describe 'managing combined and seperate java chain keys' do
     include_context 'with common variables'
 
-    it 'verifies keytool is setup', unless: os[:family] == 'windows' do # rubocop:disable RSpec/NoExpectationExample
+    it 'verifies keytool is setup', unless: os[:family] == 'windows' do
       i = 0
       loop do
         keytool_status = run_shell('keytool')
@@ -43,7 +43,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp) }.not_to raise_error
+      idempotent_apply(pp)
     end
 
     expectations_combined = [
@@ -94,7 +94,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp) }.not_to raise_error
+      idempotent_apply(pp)
 
       expectations_combined = [
         %r{Alias name: combined\.example\.com},
@@ -146,7 +146,7 @@
 
       # in noop mode, when the dependent certificate files are not present in the system,
       # java_ks will not invoke openssl to validate their status, thus noop will succeed
-      expect { apply_manifest(pp, noop: true) }.not_to raise_error
+      apply_manifest(pp, noop: true)
     end
 
     # verifies the dependent files are missing

spec/acceptance/content_spec.rb

@@ -26,7 +26,7 @@
             }
            MANIFEST
          end
-    expect { idempotent_apply(pp) }.not_to raise_error
+    idempotent_apply(pp)
   end
 
   expectations = [

spec/acceptance/destkeypass_spec.rb

@@ -19,7 +19,7 @@
       }
     MANIFEST
 
-    expect { idempotent_apply(pp) }.not_to raise_error
+    idempotent_apply(pp)
   end
 
   it 'can make a cert req with the right password' do

spec/acceptance/keystore_spec.rb

@@ -22,7 +22,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp_one) }.not_to raise_error
+      idempotent_apply(pp_one)
     end
 
     expectations = [
@@ -56,7 +56,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp_two) }.not_to raise_error
+      idempotent_apply(pp_two)
     end
 
     it 'recreates a keystore if password fails' do
@@ -73,7 +73,7 @@
       }
       MANIFEST
 
-      expect { idempotent_apply(pp_three) }.not_to raise_error
+      idempotent_apply(pp_three)
     end
 
     it 'verifies the keystore again' do
@@ -101,7 +101,7 @@
           }
         MANIFEST
 
-        expect { idempotent_apply(pp) }.not_to raise_error
+        idempotent_apply(pp)
       end
 
       expectations = [
@@ -136,7 +136,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp_one) }.not_to raise_error
+      idempotent_apply(pp_one)
     end
 
     it 'adds a certificate and key' do
@@ -152,7 +152,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp_two) }.not_to raise_error
+      idempotent_apply(pp_two)
     end
 
     expectations = [

spec/acceptance/pkcs12_spec.rb

@@ -19,7 +19,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp) }.not_to raise_error
+      idempotent_apply(pp)
     end
 
     expectations = [
@@ -48,7 +48,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp) }.not_to raise_error
+      idempotent_apply(pp)
 
       expectations = if os[:family] == 'windows' || (os[:family] == 'ubuntu' && ['20.04', '22.04'].include?(os[:release])) ||
                         (os[:family] == 'debian' && os[:release] =~ %r{^11})
@@ -90,7 +90,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp) }.not_to raise_error
+      idempotent_apply(pp)
     end
 
     expectations = [
@@ -130,7 +130,7 @@
         }
       MANIFEST
 
-      expect { idempotent_apply(pp) }.not_to raise_error
+      idempotent_apply(pp)
     end
 
     expectations = [

spec/acceptance/private_key_spec.rb

@@ -17,7 +17,7 @@
       }
     MANIFEST
 
-    expect { idempotent_apply(pp) }.not_to raise_error
+    idempotent_apply(pp)
   end
 
   expectations = [

spec/acceptance/truststore_spec.rb

@@ -20,7 +20,7 @@
         path         => #{@resource_path},
     }
     MANIFEST
-    expect { idempotent_apply(pp) }.not_to raise_error
+    idempotent_apply(pp)
   end
 
   expectations = [
@@ -49,7 +49,7 @@
         path                => #{@resource_path},
     }
     MANIFEST
-    expect { idempotent_apply(pp) }.not_to raise_error
+    idempotent_apply(pp)
   end
 
   it 'verifies the truststore again' do

spec/unit/puppet/type/java_ks_spec.rb

@@ -53,7 +53,7 @@
 
   describe 'when validating attribute values' do
     [:present, :absent, :latest].each do |value|
-      it "supports #{value} as a value to ensure" do # rubocop:disable RSpec/NoExpectationExample
+      it "supports #{value} as a value to ensure" do
         described_class.new(jks_resource.merge(ensure: value))
       end
     end