(CONT-785) Rubocop Manual Fix 6 - RSpec/StubbedMock

Author: david22swan

.rubocop_todo.yml

@@ -61,11 +61,6 @@ RSpec/ExampleLength:
 RSpec/NestedGroups:
   Max: 4
 
-# Offense count: 7
-RSpec/StubbedMock:
-  Exclude:
-    - 'spec/unit/puppet/provider/java_ks/keytool_spec.rb'
-
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: .

spec/unit/puppet/provider/java_ks/keytool_spec.rb

@@ -86,7 +86,7 @@
 
     it 'normally times out after 120 seconds' do
       cmd = '/bin/echo testing 1 2 3'
-      expect(Timeout).to receive(:timeout).with(120, Timeout::Error).and_raise(Timeout::Error)
+      allow(Timeout).to receive(:timeout).with(120, Timeout::Error).and_raise(Timeout::Error)
 
       expect { provider.run_command(cmd) }.to raise_error Puppet::Error, "Timed out waiting for 'app.example.com' to run keytool"
     end
@@ -108,6 +108,7 @@
 
       context 'when using the file based parameters for certificate and private_key' do
         # rubocop:disable RSpec/MultipleExpectations
+        # rubocop:disable RSpec/StubbedMock
         it 'converts a certificate to a pkcs12 file' do
           allow(provider).to receive(:password).and_return(resource[:password])
           allow(File).to receive(:read).with(resource[:private_key]).and_return('private key')
@@ -121,6 +122,7 @@
           provider.to_pkcs12("#{temp_dir}testing.stuff")
         end
         # rubocop:enable RSpec/MultipleExpectations
+        # rubocop:enable RSpec/StubbedMock
       end
 
       context 'when using content based parameters for certificate and private_key' do
@@ -132,6 +134,7 @@
         end
 
         # rubocop:disable RSpec/MultipleExpectations
+        # rubocop:disable RSpec/StubbedMock
         it 'converts a certificate to a pkcs12 file' do
           allow(provider).to receive(:password).and_return(resource[:password])
           allow(File).to receive(:read).with('/tmp/testing.stuff').ordered.and_return('private key')
@@ -145,6 +148,7 @@
           provider.to_pkcs12("#{temp_dir}testing.stuff")
         end
         # rubocop:enable RSpec/MultipleExpectations
+        # rubocop:enable RSpec/StubbedMock
       end
     end