Add param package_manage - #634
Conversation
| class haproxy ( | ||
| Variant[Enum['present', 'absent', 'purged', 'disabled', 'installed', 'latest'], String[1]] $package_ensure = 'present', | ||
| String $package_name = $haproxy::params::package_name, | ||
| Optional[String] $package_name = $haproxy::params::package_name, |
There was a problem hiding this comment.
I think this won't work. $haproxy::params::package_name will always provide a value. Even if you switch the datatype and pass in undef, puppet will get the default from the params.pp class.
Also I don't think setting the name to undef is the correct way to make the package installation optional. The better approach would be a new parameter, like $manage_package.
There was a problem hiding this comment.
@bastelfreak - Thx for the review! I added $package_manage and changed PR summary & description. Can you pls. have another look?
e56da54 to
b0c524c
Compare
chrisongthb
changed the title
b0c524c to
df3d717
Compare
|
Hi @chrisongthb, looks like your PR has some conflicts. Also, it seems that it breaks a fair number of unit tests. If you could address those, I'll be happy to kick off acceptance testing and start moving this forward. |
3 participants
Summary
Currently it is not possible to skip package installation.
Additional Context
This MR adds param
$package_manage, which lets the user decide on package mgmt.Related Issues (if any)
Currently none, but I can file an issue, if wanted...
Checklist
puppet apply)