Skip to content
This repository was archived by the owner on Aug 31, 2019. It is now read-only.

Conversation

@rkiyanchuk
Copy link

The puppetDefArguments region incorrectly highlights arguments if they contain functions due to braces in those functions that make the region to end at the first such argument, not at the end of definitions. See the example below:

class profile::dao::aio (
  $yum_baseurl            = hiera('yum::baseurl'),
  $yum_baseurl_deps       = hiera('yum::baseurl_deps'),

  # Comment here
  $debug                  = hiera('debug', false),
) { ... }

Suggested changes handle situations with functions in class definition better and also highlight inline comments.

Please review and feel free to express any concerns, I'll do further improvement to address those.

Ruslan Kiianchuk added 2 commits March 4, 2015 17:48
The `puppetDefArguments` region incorrectly highlights arguments if they contain functions due to braces in those functions that make the region to end at the first such argument, not at the end of definitions. See the example below:
```
class profile::dao::aio (
  $yum_baseurl            = hiera('yum::baseurl'),
  $yum_baseurl_deps       = hiera('yum::baseurl_deps'),

  # Comment here
  $debug                  = hiera('debug', false),
) { ... }
```

Suggested changes handle situations with functions in class definition better and also highlight inline comments.
Previous version had a bug and affected further class definition in `{ ... }`
This one seems ok, but still ugly. If you know better way to overcome functions inside the class arguments declaration, please let me know.
@puppetcla
Copy link

Waiting for CLA signature by @zoresvit

@zoresvit - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@rkiyanchuk
Copy link
Author

It took you guys a while to respond: 1.5 years actually. I believe the changes are trivial enough and do not need licensing, I'm not sure if they are actual 1.5 years later though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants