Log the human readable plan to debug log #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
Merged
t0yv0
reviewed
Mar 19, 2025
pkg/tfsandbox/plan.go
Outdated
| @@ -73,5 +73,11 @@ func (t *Tofu) planWithOptions(ctx context.Context, logger Logger, refreshOnly b | |||
| return nil, fmt.Errorf("error running show plan: %w", err) | |||
| } | |||
|
|
|||
| humanPlan, err := t.tf.ShowPlanFileRaw(ctx, planFile, tfexec.JSONNumber(true)) | |||
There was a problem hiding this comment.
Can probably run in parallel with ShowPlanFile right?
t0yv0
approved these changes
Mar 19, 2025
corymhall
force-pushed
the
corymhall/debug-plan
branch
from
a758987 to
69ee467
Compare
t0yv0
reviewed
Mar 19, 2025
pkg/tfsandbox/plan.go
Outdated
| plan, err := t.tf.ShowPlanFile(ctx, planFile, tfexec.JSONNumber(true)) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error running show plan: %w", err) | ||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
Go makes this kind of parallelism really awkward. You have a lot of machinery in use here, it's probably fine but heavy. A bit of Go golf, you really need only one WaitGroup or one chan, and can do a fork-join pattern. Can also leave micro-optimization for later with a comment, sorry for picking here.
func fx() (int, error) {
return 2, fmt.Errorf("f-failed")
}
func gx() (int, error) {
return 1, fmt.Errorf("g-failed")
}
func par() (int, error) {
var (
fr int
ferr error
fch chan bool = make(chan bool)
)
// fork
go func() {
defer close(fch)
fr, ferr = fx()
}()
gr, gerr := gx()
// join
<-fch
err := errors.Join(ferr, gerr)
if err != nil {
return 0, err
}
return fr + gr, nil
}
corymhall
force-pushed
the
corymhall/debug-plan
branch
from
69ee467 to
1d7bc62
Compare
corymhall
force-pushed
the
corymhall/debug-plan
branch
from
1d7bc62 to
64432ce
Compare
t0yv0
approved these changes
Mar 20, 2025
|
This PR has been shipped in release v0.0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #222 to add the human readable plan to the debug log
output.
fixes #216