Add rds example test #219
Merged
Add rds example test #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
corymhall
force-pushed
the
corymhall/examples-setup
branch
4 times, most recently
from
234ddfe to
b00ea9e
Compare
t0yv0
reviewed
Mar 18, 2025
t0yv0
reviewed
Mar 18, 2025
t0yv0
reviewed
Mar 18, 2025
| username: "complete_mysql", | ||
| port: '3306', | ||
| multi_az: true, | ||
| db_subnet_group_name: vpc.database_subnet_group_name.apply(name => name!), |
There was a problem hiding this comment.
This is cool it tests module chaining. Do unknowns behave OK in this case?
t0yv0
approved these changes
Mar 18, 2025
corymhall
force-pushed
the
corymhall/examples-setup
branch
from
b00ea9e to
ca18e6c
Compare
t0yv0
reviewed
Mar 18, 2025
| @@ -0,0 +1,5 @@ | |||
| name: rds-example | |||
There was a problem hiding this comment.
Consider adding a quick README and a script how to initialize this (pulumi package add). Since parameterized providers didn't make it into Pulumi.yaml yet this won't work OOTB.
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example test for the rds module
re #211