Add basic e2e test for RDS module #203
Conversation
There was a problem hiding this comment.
Due to Create and Destroy times being > 5 minutes each, this test verifies Preview only.
I think that length of time is fine for a test and I'm not sure testing without Create and Destroy is worth it. Diff is also an important piece to test which we lose without Create.
|
That's true but would it be really easy to promote it to a full test that also does Up? We don't mind if it takes 5 min. |
|
@t0yv0 it's easy to promote, but it takes >5 minutes in either direction so we'd expect it to take 15 minutes. |
|
I'd say do it. We can tune parallelism up if we have a lot of these. |
guineveresaenger
force-pushed
the
rds
branch
3 times, most recently
from
16b51d7 to
0019699
Compare
|
Added the test to the other TypeScript tests. It's not significantly different from them. |
This is a temprorary(?)/partial(?) fix for the inconsistent plan error. As part of creating the examples for (#203) I was running into this issue and noticed that all of the occurrences were due to the `terraform_data` resources changing from `null` to `""`. Adding this simple `try` function to always fallback to `""` seems to have fixed the issue in a lot of cases. This obviously doesn't fix the inconsistent plan issue in all cases, but it gets us unstuck for creating example tests. re #198
guineveresaenger
changed the title
|
The diff shown in the test happens on Preview and reproduces IRL. May be worth consolidating with a more real-world example. |
|
Waiting on changes from #179. |
Due to Create and Destroy times being > 5 minutes each, this test verifies Preview only.
Fixes #40