Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle logging arguments in provider's getEngineAddress #536

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

mikhailshilkov
Copy link
Member

@mikhailshilkov mikhailshilkov commented Mar 10, 2025

Passing a --logflow argument to the CLI will make it pass all its arguments to providers. This PR ports this Node.js implementation and Java implementation that discards known logging parameters from engine address calculation.

This change now requires an address while previously it was optional. I believe this is a correct change, again in line with other SDKs, but let me know if there are legit cases when address is not passed.

@mikhailshilkov mikhailshilkov requested a review from a team as a code owner March 10, 2025 10:19
@Frassle
Copy link
Member

Frassle commented Mar 10, 2025

This change now requires an address while previously it was optional. I believe this is a correct change, again in line with other SDKs, but let me know if there are legit cases when address is not passed.

It's not correct. It's valid to start a provider up with no engine and to use Attach or Handshake to attach the engine afterwards.

@mikhailshilkov mikhailshilkov marked this pull request as draft March 10, 2025 10:22
@mikhailshilkov mikhailshilkov marked this pull request as ready for review March 10, 2025 10:56
@mikhailshilkov mikhailshilkov added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2025

// Skip logging-related arguments
if (arg == "--logtostderr") continue;
if (arg.StartsWith("-v=")) continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can also be passed like "-v10" without an =

@mikhailshilkov mikhailshilkov added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit ab6d97a Mar 12, 2025
20 checks passed
@mikhailshilkov mikhailshilkov deleted the mikhailshilkov/handle-log-flow branch March 12, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants