Handle logging arguments in provider's getEngineAddress #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not correct. It's valid to start a provider up with no engine and to use Attach or Handshake to attach the engine afterwards. |
tgummerer
approved these changes
Mar 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Frassle
reviewed
Mar 12, 2025
sdk/Pulumi/Provider/Provider.cs
Outdated
|
|
||
| // Skip logging-related arguments | ||
| if (arg == "--logtostderr") continue; | ||
| if (arg.StartsWith("-v=")) continue; |
There was a problem hiding this comment.
I think this can also be passed like "-v10" without an =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a --logflow argument to the CLI will make it pass all its arguments to providers. This PR ports this Node.js implementation and Java implementation that discards known logging parameters from engine address calculation.
This change now requires an address while previously it was optional. I believe this is a correct change, again in line with other SDKs, but let me know if there are legit cases when address is not passed.