Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude resource refs from property dependencies for packaged components #488

Merged
merged 3 commits into from
Mar 16, 2025

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Feb 19, 2025

Exclude resource references from "property dependencies" for remote components (i.e. MLCs) and for Calls. This way, component providers creating outputs for component inputs based on property dependencies won't create outputs for properties that only contain resource references.

Part of pulumi/pulumi#13802

github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
Update `pulumi` submodule to the v3.153.0 tag. This brings in two new
conformance tests.

- `l1-builtin-project-root` support is being added in #466 
- `l2-component-property-deps` is blocked on .NET programgen support for
`Call` (and #488)

Somewhat suspicious that a couple generated SDKs changed (I ran the
conformance tests with `PULUMI_ACCEPT=true`). Are we not snapshot
comparing those?
@justinvp justinvp force-pushed the justin/excludedeps branch from e2a016a to 3da1d80 Compare March 14, 2025 21:38
@justinvp justinvp changed the base branch from main to justin/v3.156.0 March 14, 2025 21:39
@justinvp justinvp marked this pull request as ready for review March 14, 2025 21:42
@justinvp justinvp requested a review from a team as a code owner March 14, 2025 21:42
Base automatically changed from justin/v3.156.0 to main March 14, 2025 22:28
Exclude resource references from "property dependencies" for remote components (i.e. MLCs) and for Calls. This way, component providers creating outputs for component inputs based on property dependencies won't create outputs for properties that only contain resource references.
Enable this test with a program override since programgen does not yet support emitting method calls.
@justinvp justinvp force-pushed the justin/excludedeps branch from fd21baf to bc31f69 Compare March 14, 2025 22:58
@justinvp justinvp added this pull request to the merge queue Mar 16, 2025
Merged via the queue into main with commit 9ed12ea Mar 16, 2025
20 checks passed
@justinvp justinvp deleted the justin/excludedeps branch March 16, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants