-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update proto files #233
Update proto files #233
Conversation
0727e56
to
214cf58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize we copy these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh the choices for sharing proto files isn't great. This, or a git submodule or git subtree. But always ends up being some sort of copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I get that the PR title is straightforward but the PR really should still have some kind of description with a bit more detail, even if it's only an additional sentence or two, explaining some additional context and why the change is needed.
Update proto files to the latest published from pulumi to get access to new protocol features such as invoke transforms. (Similar to #233).
Update proto files to the latest published from pulumi to get access to new protocol features such as invoke transforms. (Similar to pulumi#233).
Update proto files to latest published from pulumi to get access to new protocol features such as transforms.