Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto files #233

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Update proto files #233

merged 1 commit into from
Mar 3, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Mar 1, 2024

Update proto files to latest published from pulumi to get access to new protocol features such as transforms.

@Frassle Frassle added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Mar 1, 2024
@Frassle Frassle force-pushed the fraser/protoUpdate branch from 0727e56 to 214cf58 Compare March 1, 2024 13:25
@Frassle Frassle requested a review from a team March 1, 2024 13:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we copy these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh the choices for sharing proto files isn't great. This, or a git submodule or git subtree. But always ends up being some sort of copy.

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I get that the PR title is straightforward but the PR really should still have some kind of description with a bit more detail, even if it's only an additional sentence or two, explaining some additional context and why the change is needed.

@Frassle Frassle added this pull request to the merge queue Mar 3, 2024
Merged via the queue into main with commit 7fc5b5c Mar 3, 2024
17 checks passed
@Frassle Frassle deleted the fraser/protoUpdate branch March 3, 2024 16:17
jkerken pushed a commit to algompluecker/pulumi-dotnet that referenced this pull request Jul 24, 2024
@justinvp justinvp mentioned this pull request Jul 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2024
Update proto files to the latest published from pulumi to get access to
new protocol features such as invoke transforms. (Similar to #233).
algompluecker pushed a commit to algompluecker/pulumi-dotnet that referenced this pull request Sep 4, 2024
Update proto files to the latest published from pulumi to get access to
new protocol features such as invoke transforms. (Similar to pulumi#233).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants