Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto] Add new API to install the Pulumi CLI from the Automation API #226

Merged
merged 16 commits into from
Jan 30, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Jan 25, 2024

We want to provide a way for the Automation API to install the Pulumi CLI so that Automation API can be used in a more standalone manner.

Ref: pulumi/pulumi#14987

@julienp julienp force-pushed the julienp/auto-install branch 3 times, most recently from 9afbba4 to 387c2eb Compare January 25, 2024 13:47
@julienp julienp requested a review from Zaid-Ajaj January 25, 2024 13:57
@julienp julienp force-pushed the julienp/auto-install branch 2 times, most recently from 43a32e6 to ed5954a Compare January 25, 2024 18:24
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still draft, but took a quick look and added some comments. I didn't look at everything yet, so may have some more comments later.

@julienp julienp force-pushed the julienp/auto-install branch from 0eca847 to a7e2adc Compare January 29, 2024 15:28
@julienp julienp force-pushed the julienp/auto-install branch from 8e779c4 to 9b6a497 Compare January 29, 2024 16:13
@julienp julienp marked this pull request as ready for review January 29, 2024 16:46
julienp and others added 2 commits January 29, 2024 18:03
Co-authored-by: Fraser Waters <[email protected]>
Co-authored-by: Fraser Waters <[email protected]>
Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julienp julienp added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 7751f63 Jan 30, 2024
@julienp julienp deleted the julienp/auto-install branch January 30, 2024 09:57
jkerken pushed a commit to algompluecker/pulumi-dotnet that referenced this pull request Jul 24, 2024
…ulumi#226)

* [auto] Add new API to install the Pulumi CLI from the Automation API

* Move async initialization code to CreateAsync

* Rename PulumiCmd -> PulumiCommand

* Get Go SDK version from pulumi-language-dotnet/go.mod

* Implement InstallWindowsAsync

* Fix download script extension

* Review comments

* Change IPulumiCommand interface to abstract class PulumiCommand

* Seal CommandResult

* Look for pulumi.exe in windows tests

* Update PulumiEnvironment test for windows

* Use LocalPulumiCommand.SkipVersionCheckVar in LocalWorkspace

* Update build/Program.fs

Co-authored-by: Fraser Waters <[email protected]>

* Update sdk/Pulumi.Automation/Pulumi.Automation.csproj

Co-authored-by: Fraser Waters <[email protected]>

* Update build/Program.fs

Co-authored-by: Fraser Waters <[email protected]>

* Update build/Program.fs

Co-authored-by: Fraser Waters <[email protected]>

---------

Co-authored-by: Fraser Waters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants