-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[auto] Add new API to install the Pulumi CLI from the Automation API #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
julienp
commented
Jan 25, 2024
9afbba4
to
387c2eb
Compare
Frassle
reviewed
Jan 25, 2024
43a32e6
to
ed5954a
Compare
justinvp
reviewed
Jan 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still draft, but took a quick look and added some comments. I didn't look at everything yet, so may have some more comments later.
0eca847
to
a7e2adc
Compare
8e779c4
to
9b6a497
Compare
Frassle
reviewed
Jan 29, 2024
Frassle
reviewed
Jan 29, 2024
Co-authored-by: Fraser Waters <[email protected]>
Co-authored-by: Fraser Waters <[email protected]>
Co-authored-by: Fraser Waters <[email protected]>
Co-authored-by: Fraser Waters <[email protected]>
Frassle
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
jkerken
pushed a commit
to algompluecker/pulumi-dotnet
that referenced
this pull request
Jul 24, 2024
…ulumi#226) * [auto] Add new API to install the Pulumi CLI from the Automation API * Move async initialization code to CreateAsync * Rename PulumiCmd -> PulumiCommand * Get Go SDK version from pulumi-language-dotnet/go.mod * Implement InstallWindowsAsync * Fix download script extension * Review comments * Change IPulumiCommand interface to abstract class PulumiCommand * Seal CommandResult * Look for pulumi.exe in windows tests * Update PulumiEnvironment test for windows * Use LocalPulumiCommand.SkipVersionCheckVar in LocalWorkspace * Update build/Program.fs Co-authored-by: Fraser Waters <[email protected]> * Update sdk/Pulumi.Automation/Pulumi.Automation.csproj Co-authored-by: Fraser Waters <[email protected]> * Update build/Program.fs Co-authored-by: Fraser Waters <[email protected]> * Update build/Program.fs Co-authored-by: Fraser Waters <[email protected]> --------- Co-authored-by: Fraser Waters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide a way for the Automation API to install the Pulumi CLI so that Automation API can be used in a more standalone manner.
Ref: pulumi/pulumi#14987