Implementation of typescript-ts-ssa example #1496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interurban
added
area/examples
kind/enhancement
Contributor
|
adding this to our triage process, thx @EronWright |
cnunciato
added
size/S
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a TypeScript Server-Side Apply (SSA) example for managing an nginx deployment with separated deployment and scaling concerns using Pulumi. Key changes include:
- Adding a new deployment in index.ts that creates an nginx deployment with specific labels and an SSA annotation.
- Creating detailed documentation in README.md to guide users on deploying and scaling the application.
- Including Pulumi.yaml configuration files for both the deploy and scale apps that define their respective roles in managing the deployment.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kubernetes-ts-ssa/deploy/index.ts | Creates the Kubernetes deployment using Pulumi and sets an initial replicas count. |
| kubernetes-ts-ssa/README.md | Provides comprehensive instructions covering deployment, scaling, and cleanup steps. |
| kubernetes-ts-ssa/scale/Pulumi.yaml | Configures the scale app, including configurable replicas with a default value of 3. |
| kubernetes-ts-ssa/deploy/Pulumi.yaml | Defines the deploy app configuration using Node.js and a brief deployment description. |
Files not reviewed (3)
- kubernetes-ts-ssa/deploy/.gitignore: Language not supported
- kubernetes-ts-ssa/deploy/package.json: Language not supported
- kubernetes-ts-ssa/deploy/tsconfig.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.