Add support for Open Approvals #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyobe
approved these changes
Oct 3, 2025
| return err | ||
| } | ||
|
|
||
| fmt.Fprintf(envcmd.esc.stdout, "Created environment open request with ID: %s\n", resp.ChangeRequests[0].ChangeRequestID) |
There was a problem hiding this comment.
note to self: there the console should have a route for viewing an open request so that this can output a link similar to https://github.com/pulumi/esc/blob/main/cmd/esc/cli/env.go#L429
There was a problem hiding this comment.
Yeah! I though about that yesterday too
There was a problem hiding this comment.
I added deep linking here: https://github.com/pulumi/pulumi-service/pull/33218
|
This PR has been shipped in release v0.19.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new Open Approvals feature in Pulumi ESC.