Rewrite in N-API for Electron 30+ compatibility #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by eliminating static references to constructors. Technique outright stolen from `tree-sitter/node-tree-sitter`.
…to something that can actually run on my system without complaining about random number generation.
(On my machine, a call to `pcre2_jit_compile` is causing test failures; not sure where the fault lies there. Commenting out the call fixed it, but is probably not a great idea as a permanent fix.)
DeeDeeG
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
I'm willing to more or less rubber-stamp approve this on the basis it's already been in use on the ElectronNext / Pulsar Next branch of Pulsar for a while, right?
Ideally we would have a subject-matter expert sift through hundreds of C++ files and such, but... I don't see that happening. So I think we will use this and have the proof of the pudding be in the eating, so to speak.
In that sense, Looks Good To Me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the upgrade to
superstringwe need for PulsarNext.Here's what this does:
superstringso that it usesnode-addon-apiinstead ofnan, gaining context-awareness in the process.Now that we've published our existing
superstringversion (relied on for mainline Pulsar) to NPM as@pulsar-edit/superstringversion2.5.0, we can land this tomasterand bump the major version, publishing it as version3.0.0.