-
-
Notifications
You must be signed in to change notification settings - Fork 39
Random website ideas #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11ty-migration
Are you sure you want to change the base?
Random website ideas #306
Conversation
…and to work a bit better with the one-platform-at-a-time idea.
* Major LESS addition/overhaul * Homepage concept * Concept for download page — show only one platform at a time to make it less confusing (platform auto-picked by system switcher) * Pull in Font Awesome in the header * Rework some pages
…ithub.io into 11ty-migration-random-ideas
Overall, I absolutely love the changes you've made! Plus the new homepage does indeed look fantastic, and still carries the improvements made previously from another contributor, while still having significantly better performance, taking about half the memory of the current homepage at peak and taking 3.5CPU compared to our current 18CPU according to Google Chrome's built in Task Manager. The only issue I can even find in this comes from the Auto TOC. On the download page the sub content of Absolutely fantastic changes in this PR, and I really appreciate the assistance on this front as I know I've been taking my time working on it. |
layouts/footer.ejs
Outdated
<section class="page-footer__section"> | ||
<header class="page-footer__section-title">Team</header> | ||
<ul class="page-footer__links"> | ||
<li><a href="/blog">Blog</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li><a href="/blog">Blog</a></li> | |
<li><a href="https://blog.pulsar-edit.dev">Blog</a></li> |
Get this to match our new blog destination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Will /blog
redirect to the subdomain automatically? Want to make sure we don't break existing permalinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, that needs to be added to this site in our redirects directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we be able to do it on a bulk basis? For instance, a wildcard rewrite of
https://pulsar-edit.dev/blog/20240902-savetheclocktower-modern-tree-sitter-part-7.html
to
http://blog.pulsar-edit.dev/posts/20240902-savetheclocktower-modern-tree-sitter-part-7/
?
Thanks for the feedback. Now that the data file is JS instead of JSON, I'm going to take a pass and simplify it a bit — no need for an elaborate system of includes when I can just define variables and reduce duplication that way. |
This is a bunch of stuff in one PR, but I don't mind if I'm asked to revert any of this. The download-page stuff in particular conflicts with an idea that @confused-Techie had, but I just wanted to get it on the canvas to see if it was workable.
Here's what's in this PR:
@11ty/font-awesome
doesn't seem to work with EJS #305download.11tydata.json
— most strings that existed more than once in the file are now defined in a single placeLet me know what you think.