Skip to content

Random website ideas #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 11ty-migration
Choose a base branch
from

Conversation

savetheclocktower
Copy link
Contributor

This is a bunch of stuff in one PR, but I don't mind if I'm asked to revert any of this. The download-page stuff in particular conflicts with an idea that @confused-Techie had, but I just wanted to get it on the canvas to see if it was workable.

Screenshot 2025-06-15 at 7 39 09 PM

Here's what's in this PR:

  • Switching to a manual Font Awesome implementation due to @11ty/font-awesome doesn't seem to work with EJS #305
  • Tried out some ideas for the homepage:
    • Starfield rendered only in CSS (no JS necessary; should make folks' computers happier)
    • Early reference to the Atom legacy
    • Actual screenshot of the editor
    • A few more bullet points explaining the cool stuff about Pulsar
  • Download page idea: show only one platform at a time!
    • We already made a platform switcher UI for the docs site, and it already makes an educated guess at what platform you're currently on
    • So when you hit the download page, you're shown just one platform's downloads — though you can switch to others via the UI
    • This affects everything — which headings you get shown in the sidebar, even!
    • Tried to reduce redundancy in download.11tydata.json — most strings that existed more than once in the file are now defined in a single place
  • Rephrased some language on various pages

Let me know what you think.

…and to work a bit better with the one-platform-at-a-time idea.
* Major LESS addition/overhaul
* Homepage concept
* Concept for download page — show only one platform at a time to make it less confusing (platform auto-picked by system switcher)
* Pull in Font Awesome in the header
* Rework some pages
@confused-Techie
Copy link
Member

Overall, I absolutely love the changes you've made!
While the download page is different than the idea I had, I think still reducing our page of reading to a rather simple list, and having it only display one platform at a time does what I wanted to do, which was simplify the experience of finding the right installation method, so that still totally works for me.

Plus the new homepage does indeed look fantastic, and still carries the improvements made previously from another contributor, while still having significantly better performance, taking about half the memory of the current homepage at peak and taking 3.5CPU compared to our current 18CPU according to Google Chrome's built in Task Manager.

The only issue I can even find in this comes from the Auto TOC. On the download page the sub content of Package managers is appearing underneath Rolling releases for some reason, and the href link isn't translating includes labels, so although they still work the source looks kinda iffy. Beyond those two issues though I'd fully support merging this and calling the website nearly perfect, with us just needing to update the footer blog link to point to the new upcoming site, and then adding in the content for things like our privacy policy.

Absolutely fantastic changes in this PR, and I really appreciate the assistance on this front as I know I've been taking my time working on it.

<section class="page-footer__section">
<header class="page-footer__section-title">Team</header>
<ul class="page-footer__links">
<li><a href="/blog">Blog</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="/blog">Blog</a></li>
<li><a href="https://blog.pulsar-edit.dev">Blog</a></li>

Get this to match our new blog destination.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Will /blog redirect to the subdomain automatically? Want to make sure we don't break existing permalinks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, that needs to be added to this site in our redirects directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be able to do it on a bulk basis? For instance, a wildcard rewrite of

https://pulsar-edit.dev/blog/20240902-savetheclocktower-modern-tree-sitter-part-7.html

to

http://blog.pulsar-edit.dev/posts/20240902-savetheclocktower-modern-tree-sitter-part-7/

?

@savetheclocktower
Copy link
Contributor Author

Thanks for the feedback. Now that the data file is JS instead of JSON, I'm going to take a pass and simplify it a bit — no need for an elaborate system of includes when I can just define variables and reduce duplication that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants