Add Sequoia (sq) backend support to add-signing-service - #7946
Draft
dralley wants to merge 1 commit into
Draft
Conversation
dralley
force-pushed
the
pqc-signing-service
branch
from
August 5, 2026 22:06
e0372ae to
d195d4d
Compare
dralley
commented
Aug 6, 2026
| help=_("A default GnuPG home directory to use during the initialization."), | ||
| help=_( | ||
| "Home directory for the key management backend. " | ||
| "For GPG, defaults to $GNUPGHOME. For sq, defaults to $SEQUOIA_HOME." |
Contributor
Author
There was a problem hiding this comment.
We're re-using this, which I think is fine, but should we also have a more generically named alias and deprecate --gnupghome?
Contributor
There was a problem hiding this comment.
Concur - can we get a --home switch? If you use --gnupghome and --backend sq we will do The Right Thing, but long term, that adds some user-confusion - so yeah, let's deprecate --gnupghome (maybe 130, or possibly even further?)
dralley
force-pushed
the
pqc-signing-service
branch
from
August 6, 2026 03:37
d195d4d to
8663b89
Compare
dralley
force-pushed
the
pqc-signing-service
branch
from
August 6, 2026 03:38
8663b89 to
7d63a0b
Compare
dralley
commented
Aug 6, 2026
dralley
force-pushed
the
pqc-signing-service
branch
from
August 6, 2026 03:41
7d63a0b to
af0b384
Compare
dralley
commented
Aug 6, 2026
dralley
force-pushed
the
pqc-signing-service
branch
from
August 6, 2026 03:44
af0b384 to
2ed5b68
Compare
The add-signing-service management command previously hardcoded GPG for key metadata extraction, preventing use with key types GPG cannot handle (OpenPGP v6, ML-DSA/post-quantum). This adds a --backend option that accepts "gpg" (default, existing behavior) or "sq" (Sequoia). Both backends reuse --gnupghome and --keyring, mapped to the equivalent sq CLI flags. The sq backend uses `sq cert export` to retrieve the public key and pysequoia to parse the fingerprint. Test infrastructure gains parallel Sequoia fixtures and helpers (import_signing_key_sq, make_sq_signing_script, create_signing_service_sq) and both signing service tests are parametrized to run with both backends. Assisted-By: Claude Opus 4.6 closes pulp#7479
dralley
force-pushed
the
pqc-signing-service
branch
from
August 6, 2026 13:30
2ed5b68 to
47e1292
Compare
dralley
commented
Aug 6, 2026
| ) | ||
| parser.add_argument( | ||
| "--gnupghome", | ||
| default=os.getenv("GNUPGHOME", ""), |
Contributor
Author
There was a problem hiding this comment.
TODO: This should be None, default selection should happen only in the handler code, based on a branch on backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The add-signing-service management command previously hardcoded GPG for key metadata extraction, preventing use with key types GPG cannot handle (OpenPGP v6, ML-DSA/post-quantum). This adds a --backend option that accepts "gpg" (default, existing behavior) or "sq" (Sequoia). Both backends reuse --gnupghome and --keyring, mapped to the equivalent sq CLI flags. The sq backend uses
sq cert exportto retrieve the public key and pysequoia to parse the fingerprint.Test infrastructure gains parallel Sequoia fixtures and helpers (import_signing_key_sq, make_sq_signing_script, create_signing_service_sq) and both signing service tests are parametrized to run with both backends.
Assisted-By: Claude Opus 4.6
closes #7479