Adopts new content_summary layout #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
force-pushed
the
add-counts-and-serializers
branch
from
41ecc0c to
b13d7e4
Compare
bmbouter
force-pushed
the
add-counts-and-serializers
branch
3 times, most recently
from
4fa39bc to
8a4c80b
Compare
|
This change needs to be evaluated in all the other plugins. |
bmbouter
force-pushed
the
add-counts-and-serializers
branch
from
8a4c80b to
ee57bc6
Compare
bmbouter
pushed a commit
to bmbouter/plugin_template
that referenced
this pull request
Mar 1, 2019
Due to the breaking change in the PR below, the resonse format has changed. No user facing features need updating, only the test assertions change by updating the fixture data. Required PR: pulp/pulpcore#2 https://pulp.plan.io/issues/4283 re #4283
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
+ Coverage 76.07% 76.17% +0.09%
==========================================
Files 64 64
Lines 2825 2820 -5
==========================================
- Hits 2149 2148 -1
+ Misses 676 672 -4
Continue to review full report at Codecov.
|
The performance issue causes us to introduce a new model named RepositoryVersionContentDetails. This is also a great opportunity to update the content_summary of the RepositoryVersion serializer to match the recent API changes. Most of this code was inspired from a patch from @dalley. This includes smash updates that are included in a separate PR to preserve backwards compatability. Required PR: pulp/pulp-smash#1174 This also fixes travis script lines that weren't updated due to pulp/pulp being moved to pulp/pulpcore. This PR needs that small fix to pass also. https://pulp.plan.io/issues/4283 closes pulp#4283
bmbouter
force-pushed
the
add-counts-and-serializers
branch
from
ee57bc6 to
fe52153
Compare
dralley
approved these changes
Mar 1, 2019
|
@bmbouter This is a great improvement! Thank you for doing this work. |
rochacbruno
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance issue causes us to introduce a new model named
RepositoryVersionContentDetails. This is also a great opportunity to
update the content_summary of the RepositoryVersion serializer to match
the recent API changes.
Most of this code was inspired from a patch from @dalley.
This includes smash updates that are included in a separate PR to
preserve backwards compatability.
Required PR: pulp/pulp-smash#1174
This also fixes travis script lines that weren't updated due to
pulp/pulp being moved to pulp/pulpcore. This PR needs that small fix to
pass also.
https://pulp.plan.io/issues/4283
closes #4283