Skip to content

Settings.import #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdellweg merged 2 commits into from
Jul 17, 2026
Merged

Settings.import #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bad064
Add guard to prevent bad settings import
mdellweg Jul 15, 2026
f74899f
Template django_secret in CI
mdellweg Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/github/.ci/ansible/settings.py.j2.copy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
SECRET_KEY = "{{ django_secret }}"
CONTENT_ORIGIN = "{{ pulp_scheme }}://pulp:{{ 443 if pulp_scheme == 'https' else 80 }}"
ANSIBLE_API_HOSTNAME = "{{ pulp_scheme }}://pulp:{{ 443 if pulp_scheme == 'https' else 80 }}"
ANSIBLE_CONTENT_HOSTNAME = "{{ pulp_scheme }}://pulp:{{ 443 if pulp_scheme == 'https' else 80 }}/pulp/content"
Expand Down
2 changes: 2 additions & 0 deletions templates/github/.ci/ansible/start_container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
ansible.builtin.template:
src: "settings.py.j2"
dest: "settings/settings.py"
vars:
django_secret: "lookup('community.general.random_string', length=50, overwrite_all='abcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*(-_=+)')"

- name: "Setup docker networking"
community.docker.docker_network:
Expand Down
1 change: 1 addition & 0 deletions templates/github/pyproject.toml.tool.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ extend-select = [
[tool.ruff.lint.flake8-tidy-imports.banned-api]
# This section is managed by the plugin template. Do not edit manually.
"distutils".msg = "The 'distutils' module has been deprecated since Python 3.9."
"pulpcore.app.settings".msg = "Always import 'settings' from 'django.conf' instead."
{%- if plugin_name != "pulpcore" %}
"pulpcore.app".msg = "The 'pulpcore' apis must only be consumed via 'pulpcore.plugin'."
{%- endif %}
Expand Down