Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove main search bar from advanced search form #3869

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Remove main search bar from advanced search form #3869

merged 1 commit into from
Dec 5, 2023

Conversation

christinach
Copy link
Member

closes #3760

@christinach christinach force-pushed the 3760-search-bar-advanced-form branch from f916375 to 8d156a1 Compare December 4, 2023 20:14
@christinach christinach marked this pull request as draft December 4, 2023 20:40
@christinach christinach force-pushed the 3760-search-bar-advanced-form branch 3 times, most recently from bc3cedb to 568c628 Compare December 4, 2023 23:54
@christinach christinach marked this pull request as ready for review December 4, 2023 23:54
@christinach
Copy link
Member Author

Deployed on catalog-qa

@christinach christinach force-pushed the 3760-search-bar-advanced-form branch from 568c628 to b7401e7 Compare December 4, 2023 23:55
@coveralls
Copy link

Coverage Status

coverage: 95.402% (-0.003%) from 95.405%
when pulling b7401e7 on 3760-search-bar-advanced-form
into 3b8dddb on main.

@kevinreiss
Copy link
Member

This branch seems to work well with the regular advanced search screen and the numismatics screen. Tested on catalog-qa.

@kevinreiss kevinreiss closed this Dec 5, 2023
@kevinreiss kevinreiss reopened this Dec 5, 2023
@kevinreiss kevinreiss merged commit bc87871 into main Dec 5, 2023
3 checks passed
@kevinreiss kevinreiss deleted the 3760-search-bar-advanced-form branch December 5, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinreiss kevinreiss kevinreiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the search bar in the advanced search screen
3 participants
@christinach @coveralls @kevinreiss