Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit biased results feedback #3822

Merged
merged 26 commits into from
Nov 21, 2023
Merged

Submit biased results feedback #3822

merged 26 commits into from
Nov 21, 2023

Conversation

hectorcorrea
Copy link
Member

@hectorcorrea hectorcorrea commented Nov 8, 2023 •
edited
Loading

First pass at creating the form to allow the users to submit feedback related to biased search results.

Works towards #3789

@coveralls
Copy link

coveralls commented Nov 8, 2023 •
edited
Loading

Coverage Status

coverage: 95.464% (-0.003%) from 95.467%
when pulling f6212a7 on 3789-biased-results-form
into 6954b68 on main.

@hectorcorrea @leefaisonr
Created a sample feedback form.
810e779 
Code does not process the results, only accepts the user submission.

Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
@hectorcorrea hectorcorrea changed the title Started adding the form to submit biased results feedback Submit biased results feedback Nov 9, 2023
leefaisonr and others added 12 commits November 9, 2023 14:22
@leefaisonr @hectorcorrea @Seanwarren77
Use form helpers for biased search results
33ed16a 
Co-authored-by: Hector Correa <[email protected]>
Co-authored-by: Sean Warren <[email protected]>
@hectorcorrea @leefaisonr
Pass the search terms to the biased results form
bc994bb 
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
@hectorcorrea
Pass the entire query string from the search results to the biased re…
5271caf 
…port form
@Seanwarren77
Merge branch 'main' into 3789-biased-results-form
0a47ce5
@sdellis
First attempt at creating a modal form for reporting biased results. …
7d224a8 
…(WIP)

 Co-authored-by: Jane Sandberg <[email protected]>
 Co-authored-by: Kate Lynch <[email protected]>
 Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
 Co-authored-by: Shaun Ellis <[email protected]>
@leefaisonr @hackartisan
@bess @sandbergja @kelynch @sdellis @Seanwarren77 @Twade968
Fix routing
8d2298d 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Bess Sadler <[email protected]>
Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Kate Lynch <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Sean Warren <[email protected]>
Co-authored-by: Tyler Wade <[email protected]>
@sdellis
Modal now works; added tests for the Form; updated config files
6f6ec47 
Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Sean Warren <[email protected]>
@sdellis
Started a feature test for the modal form for reporting biased results
7c99311 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
@leefaisonr @hackartisan
@kelynch @tpendragon
Get the query out of the form
94c831f 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Kate Lynch <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@kelynch
Moved test to controller tests
8950167 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Kate Lynch <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@leefaisonr @kelynch @tpendragon
Added a link to the current search
5a3e745 
Co-authored-by: Kate Lynch <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@leefaisonr
rubocop corrections
d5155c6
@sdellis
Copy link
Member

sdellis commented Nov 16, 2023

An update to the mockup that simplifies our initial approach to providing context for the user can be found in the comments on the original ticket.

leefaisonr and others added 12 commits November 16, 2023 11:59
@leefaisonr @hackartisan
@sandbergja @sdellis
Adjust routes for form submission
102ef38 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
@sandbergja
Get test passing
e181449
@sandbergja @hackartisan
Convert biased results form to simple_form and fix styling
7b9b94e 
Co-authored-by: Anna Headley <[email protected]>
@hackartisan @sdellis @sandbergja
Work toward passing full search query string in context
88f99af 
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Jane Sandberg <[email protected]>
@sdellis
Splits search query into separate parameters for safety and convenience
b496c0b 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Sean Warren <[email protected]>
@hackartisan @tpendragon @leefaisonr
Render context into url and fix test
8909ea5 
Co-authored-by: Trey Pendragon <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
@hackartisan @tpendragon @leefaisonr
Remove q from report biased results form
4db209c 
Co-authored-by: Trey Pendragon <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
@hackartisan @tpendragon @leefaisonr
Pass the full url you're coming from
3c19d78 
Co-authored-by: Trey Pendragon <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
@hackartisan
Add integration test that email gets sent
8b99da7
@kelynch
Make search results link open in new tab
cd5b71f
@kelynch
Added indication that link opens in a new tab
51321ed
@sandbergja
Merge pull request #3842 from pulibrary/3789-biased-results-form-c
f6212a7 
Make search results link open in new tab
@sandbergja sandbergja marked this pull request as ready for review November 21, 2023 15:57
sandbergja
sandbergja approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, group 3!

@sandbergja sandbergja merged commit a56c20b into main Nov 21, 2023
@sandbergja sandbergja deleted the 3789-biased-results-form branch November 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandbergja sandbergja sandbergja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hectorcorrea @coveralls @sdellis @sandbergja @leefaisonr @Seanwarren77 @kelynch @hackartisan