Users and Spaces V3 implementation #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seba-aln
requested review from
kleewho and
marek-lewandowski
as code owners
| @@ -99,7 +100,8 @@ def request_headers(self): | |||
| headers["Content-Encoding"] = "gzip" | |||
| if self.http_method() == HttpMethod.POST: | |||
| headers["Content-type"] = "application/json" | |||
|
|
|||
| if self._custom_headers: | |||
There was a problem hiding this comment.
https://peps.python.org/pep-0008/#programming-recommendations
Initially self._custom_headers is equal None. In this case you should check if your variable is None or not. I assume that custom_headers variable is a dict. So you can change initial value from None to empty dict ;)
| else: | ||
| raise ValueError() | ||
|
|
||
| if len(inclusions) > 0: |
|
|
||
| params["sort"] = ",".join(joined_sort_params_array) | ||
|
|
||
| if self._page: |
There was a problem hiding this comment.
_page could be None? If yes you should check it here ;)
| from pubnub.models.consumer.entities.space import PNCreateSpaceResult, PNFetchSpaceResult, PNFetchSpacesResult, \ | ||
| PNUpdateSpaceResult, PNUpsertSpaceResult | ||
|
|
||
| from pubnub.pubnub import PubNub |
There was a problem hiding this comment.
Decide which import way you want to use in this file and then stick to it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.