refactor: avoid re subscribe for already subscribed entities #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2025 11:09
…ribe request contain existing channels or groups
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mohitpubnub
added
the
type: refactor
parfeon
reviewed
Dec 1, 2025
src/event-engine/index.ts
Outdated
Comment on lines
131
to
132
| affectedChannels: Array.from(new Set(this.channels.filter((c) => !c.endsWith('-pnpres')))), | ||
| affectedChannelGroups: Array.from(new Set(this.groups.filter((g) => !g.endsWith('-pnpres')))), |
Contributor
There was a problem hiding this comment.
@mohitpubnub is there a reason to filter out presence channels?
Contributor
Author
There was a problem hiding this comment.
I think filter is not needed. I tested it now, we do not filter out presence channels from status event.
…d status event in re-subscribe scenario
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(subscribe): prevent resubscribing to already subscribed entities.
Prevent resubscribe to previously subscribed entities.