Skip to content

Commit

Permalink
Merge pull request #129 from pubnub/develop
Browse files Browse the repository at this point in the history
Develop
  • Loading branch information
ManuelFernando authored Apr 27, 2018
2 parents 9670064 + e903f30 commit 95cb5ef
Show file tree
Hide file tree
Showing 16 changed files with 50 additions and 22 deletions.
9 changes: 8 additions & 1 deletion .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
name: javascript
version: 4.20.2
version: 4.20.3
schema: 1
scm: github.com/pubnub/javascript
files:
- dist/web/pubnub.js
- dist/web/pubnub.min.js
changelog:
- version: v4.20.3
date: 2018-04-24
changes:
- type: bug
text: fix timetoken announces
- type: improvement
text: categorize ETIMEDOUT errors as PNNetworkIssuesCategory
- version: v4.20.2
date: 2018-02-28
changes:
Expand Down
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
## [v4.20.3](https://github.com/pubnub/javascript/tree/v4.20.3)
Abril-24-2018


[Full Changelog](https://github.com/pubnub/javascript/compare/v4.20.2...v4.20.3)



- 🐛fix timetoken announces


- ⭐categorize ETIMEDOUT errors as PNNetworkIssuesCategory



## [v4.20.2](https://github.com/pubnub/javascript/tree/v4.20.2)
February-28-2018

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ please use the [master_3x](https://github.com/pubnub/javascript/tree/master_3x)

## CDN Links

* https://cdn.pubnub.com/sdk/javascript/pubnub.4.20.2.min.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.20.2.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.20.3.min.js
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.20.3.js
8 changes: 5 additions & 3 deletions dist/titanium/pubnub.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! 4.20.2 / Consumer */
/*! 4.20.3 / Consumer */
(function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory();
Expand Down Expand Up @@ -586,7 +586,7 @@ return /******/ (function(modules) { // webpackBootstrap
}, {
key: 'getVersion',
value: function getVersion() {
return '4.20.2';
return '4.20.3';
}
}, {
key: '_decideUUID',
Expand Down Expand Up @@ -1507,7 +1507,7 @@ return /******/ (function(modules) { // webpackBootstrap
this._currentTimetoken = timetoken;
}

if (this._currentTimetoken !== '0') {
if (this._currentTimetoken !== '0' && this._currentTimetoken !== 0) {
this._storedTimetoken = this._currentTimetoken;
this._currentTimetoken = 0;
}
Expand Down Expand Up @@ -4573,6 +4573,8 @@ return /******/ (function(modules) { // webpackBootstrap
if (err.status === 0 || err.hasOwnProperty('status') && typeof err.status === 'undefined') return _categories2.default.PNNetworkIssuesCategory;
if (err.timeout) return _categories2.default.PNTimeoutCategory;

if (err.code === 'ETIMEDOUT') return _categories2.default.PNNetworkIssuesCategory;

if (err.response) {
if (err.response.badRequest) return _categories2.default.PNBadRequestCategory;
if (err.response.forbidden) return _categories2.default.PNAccessDeniedCategory;
Expand Down
4 changes: 2 additions & 2 deletions dist/titanium/pubnub.min.js

Large diffs are not rendered by default.

8 changes: 5 additions & 3 deletions dist/web/pubnub.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! 4.20.2 / Consumer */
/*! 4.20.3 / Consumer */
(function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory();
Expand Down Expand Up @@ -608,7 +608,7 @@ return /******/ (function(modules) { // webpackBootstrap
}, {
key: 'getVersion',
value: function getVersion() {
return '4.20.2';
return '4.20.3';
}
}, {
key: '_decideUUID',
Expand Down Expand Up @@ -1529,7 +1529,7 @@ return /******/ (function(modules) { // webpackBootstrap
this._currentTimetoken = timetoken;
}

if (this._currentTimetoken !== '0') {
if (this._currentTimetoken !== '0' && this._currentTimetoken !== 0) {
this._storedTimetoken = this._currentTimetoken;
this._currentTimetoken = 0;
}
Expand Down Expand Up @@ -4595,6 +4595,8 @@ return /******/ (function(modules) { // webpackBootstrap
if (err.status === 0 || err.hasOwnProperty('status') && typeof err.status === 'undefined') return _categories2.default.PNNetworkIssuesCategory;
if (err.timeout) return _categories2.default.PNTimeoutCategory;

if (err.code === 'ETIMEDOUT') return _categories2.default.PNNetworkIssuesCategory;

if (err.response) {
if (err.response.badRequest) return _categories2.default.PNBadRequestCategory;
if (err.response.forbidden) return _categories2.default.PNAccessDeniedCategory;
Expand Down
6 changes: 3 additions & 3 deletions dist/web/pubnub.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/core/components/config.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/core/components/config.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/core/components/subscription_manager.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/core/components/subscription_manager.js.map

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions lib/networking/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/networking/index.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pubnub",
"version": "4.20.2",
"version": "4.20.3",
"author": "PubNub <[email protected]>",
"description": "Publish & Subscribe Real-time Messaging with PubNub",
"bin": {},
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export default class {
setSendBeaconConfig(val: boolean): this { this._useSendBeacon = val; return this; }

getVersion(): string {
return '4.20.2';
return '4.20.3';
}

_decideUUID(providedUUID: string): string {
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/subscription_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export default class {
}

// reset the current timetoken to get a connect event.
if (this._currentTimetoken !== '0') {
if (this._currentTimetoken !== '0' && this._currentTimetoken !== 0) {
this._storedTimetoken = this._currentTimetoken;
this._currentTimetoken = 0;
}
Expand Down

0 comments on commit 95cb5ef

Please sign in to comment.