fix: ARM (Apple Silicon) build support in Dockerfile #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch-21
force-pushed
the
catch-21/dockerfile-arm
branch
from
5bbd402 to
43e30b3
Compare
SHAcollision
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thank you @catch-21 , I can't test but looks good! Feel free to merge
|
I tested on M3 Mac with the new arg and x86 AMD linux machine without the new arg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still defaults to x86. Pass build arg when using ARM architecture:
docker build --build-arg TARGETARCH=aarch64 .