fix(common): Session::deserialize better error for empty payloads

pubky · Sep 28, 2024 · e031c7a · e031c7a
1 parent f2a4fe3
commit e031c7a
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/pubky-common/src/session.rs b/pubky-common/src/session.rs
@@ -68,6 +68,10 @@ impl Session {
     }
 
     pub fn deserialize(bytes: &[u8]) -> Result<Self> {
+        if bytes.is_empty() {
+            return Err(Error::EmptyPayload);
+        }
+
         if bytes[0] > 0 {
             return Err(Error::UnknownVersion);
         }
@@ -82,6 +86,8 @@ pub type Result<T> = core::result::Result<T, Error>;
 
 #[derive(thiserror::Error, Debug)]
 pub enum Error {
+    #[error("Empty payload")]
+    EmptyPayload,
     #[error("Unknown version")]
     UnknownVersion,
     #[error(transparent)]
@@ -123,4 +129,9 @@ mod tests {
 
         assert_eq!(deseiralized, session)
     }
+
+    #[test]
+    fn deserialize() {
+        let deseiralized = Session::deserialize(&[]).unwrap();
+    }
 }