Slight re-wording/text inserts #651
Conversation
Slightly clarified, mentioned that 127.0.0.1 should not be used unless a proxy is in place/user knows what they are doing
| @@ -100,7 +100,7 @@ After you've downloaded all of the new files you will need to upgrade the core c | |||
| simply run the commands below and follow any prompts. | |||
|
|
|||
| ```bash | |||
| composer install --no-dev --optimize-autoloader | |||
There was a problem hiding this comment.
I dont think it's a good idea to recommend that because it's a security risk and afaik not needed in 99% of the cases (and if needed then they prob is a file perm issue)
There was a problem hiding this comment.
Put it there to try and follow through with the first install segment, as that has the same thing too, and I feel it sometimes causes issues for people
There was a problem hiding this comment.
Maybe it as change though but if it's added prob add a warning on the impact of that env var
There was a problem hiding this comment.
As composer's own documentation states, composer shouldn't be run as root.
Instead of arbitrarily ignoring the warning, it's perhaps best to guide people to composer's documentation instead, although, I don't believe it should be up to pterodactyl's documentation to solve every single problem unrelated to pterodactyl itself.
The catch-all phrase under getting started should apply to this:
If you expect to be able to install this with no understanding of basic linux system administration you should stop and turn around now.
| @@ -174,4 +174,4 @@ Allocation is a combination of IP and Port that you can assign to a server. Each | |||
|
|
|||
|  | |||
|
|
|||
| Type `hostname -I | awk '{print $1}'` to find the IP to be used for the allocation. Alternatively, you can type `ip addr | grep "inet "` to see all your available interfaces and IP addresses. Do not use 127.0.0.1 for allocations. | |||
| Type `hostname -I | awk '{print $1}'` to find the IP to be used for the allocation. Alternatively, you can type `ip addr | grep "inet "` to see all your available interfaces and IP addresses. Do not use 127.0.0.1 for allocations, *unless you know what you are doing/using a [Minecraft Proxy](https://pterodactyl.io/community/games/minecraft.html)*. | |||
There was a problem hiding this comment.
Maybe a more general link to proxy, because even if ptero seems a lot used for Miencraft it's not the only game hosted
There was a problem hiding this comment.
afaik the most common use for proxies with Pterodactyl is Minecraft, and so far it is the only one with a community guide
Mentioned that
COMPOSER_ALLOW_SUPERUSER=1should be ran when upgrading the panel, and also mentioned how 127.0.0.1 shouldn't be used, unless the user knows what they are doing/has a proxy in place.