apply freshness checks to redirects with explicit expiration - #468
Merged
Conversation
woodruffw
approved these changes
Aug 29, 2026
Member
|
Thank you @ogalland-tob! Seems right to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CacheControl treats stored 301 and 308 responses as permanently reusable. It returns them before evaluating response freshness or cache-control directives.
This is a bit tricky, but RFC 9111 section 4.2.2 states:
If we take cachecontrol's heuristic to be "the response is permanently fresh" then (afaiu) this would mean that redirect responses with explicit expiration dates can expire and thus should be checked for freshness (i.e., the explicit expiration takes precedence over the heuristic).
This PR applies the usual freshness checks to redirects, and introduces a fallback to still treat them as permanently fresh if the response is not expired. It also introduces relevant unit tests.