Configurable behaviour for cookie defaults and overrides #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this and create a new gem version! |
|
I haven't merged this because I think it goes beyond the scope of this gem. The gem is really just intended to patch over the behavior of older rails apps so they can continue working as they were before in newer versions of Chrome. Given the direction browsers are going it's not really meant to be a permanent solution and most of these apps will need to find ways to move away from the use of third party cookies in the near future. It already doesn't work in Safari unless the user changes their settings and there's talk of Chrome eventually disallowing these kinds of cookies in a similar way as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I offer one solution on the issue #2.