Repository navigation
Baseline the exception messages printf prints as has_quotes, now a printf sink - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vimeo/psalm#12210 made printf a sink of the same taint kinds as echo, so it now also takes has_quotes. TextUI/Application.php printf()s the exception message and trace to the terminal, already baselined as TaintedHtml; this adds the matching TaintedTextWithQuotes entries. These are real flows in a CLI tool, the same as the print of the message already baselined. Fixes the vimeo/psalm CircleCI test-with-real-projects failure on master (b3a4cf454).