Cleanup s assembly files #733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtrujy
reviewed
Jan 28, 2025
| @@ -367,6 +383,36 @@ static volatile unsigned int *func_00000f80(volatile unsigned int *address) | |||
|
|
|||
| // 0x00001b38 | |||
| void func_00001b38(unsigned int arg1); | |||
| __asm__ | |||
There was a problem hiding this comment.
Shouldn't be better if we use the asm code directly inside of the function? instead of defining the header and then implementing the "whole" function using ASM?
There was a problem hiding this comment.
That would be better, but I plan to do that in another pass (not in this PR) because it requires figuring out what registers are read/written/clobbered and that has a higher change of breaking.
|
Anyway, as this PR is risky, I would like to split this PR into smaller PRs, to check that the implementation is exactly the same. |
|
Yeah, I can do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some unused s files, so those have been removed.
There were some s files that have intermixed C preprocessor statements and assembly, so those have been cleaned up and made such that the C preprocessor statements have been more isolated from the assembly code.
Tested wLE can launch itself
Tested OPL can run games from USB