-
Notifications
You must be signed in to change notification settings - Fork 70
[WIP] repo: Shift cargo-raze
-> crate_universe
#390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
596ce4a
to
d73b5f8
Compare
@martijneken @PiotrSikora ive had a go at this but hit a bit of a wall if i dont update bazel >= 7 then i get ERROR: /home/worker/.cache/bazel/_bazel_worker/04780f9507b63ffdcfd2ed5ffb5c93b3/external/rules_rust/rust/platform/BUILD.bazel:6:24: no such target '@platforms//os:fuchsia': target 'fuchsia' not declared in package 'os' defined by /home/worker/.cache/bazel/_bazel_worker/04780f9507b63ffdcfd2ed5ffb5c93b3/external/platforms/os/BUILD (Tip: use `query "@platforms//os:*"` to see all the targets in that package) and referenced by '@rules_rust//rust/platform:aarch64-fuchsia' updating to 7+ i get a stack of errors like external/proxy_wasm_cpp_sdk/proxy_wasm_api.h:61:33: error: no type named 'string_view' in namespace 'std'
inline WasmResult logTrace(std::string_view logMessage) { i tried forcing it to use c++17 with build --action_env=BAZEL_CXXOPTS="-std=c++17"
build --action_env=BAZEL_COPTS="-std=c++17" i get clang-14: error: unsupported option '--no-entry'
clang-14: error: unsupported option '--js-library=external/proxy_wasm_cpp_sdk/proxy_wasm_intrinsics.js'
clang-14: error: unknown argument: '-sSTANDALONE_WASM' clang-14: error: unknown argument: '-sEXPORTED_FUNCTIONS=_malloc' vendoring the crate deps works - but trying to compile anything with them fails as above |
Sorry, I missed this comment until now!
Why are rust builds targeting fuchsia here? Have you tried using
FWIW that looks like the namespace pollution issue fixed in #365. |
i didnt - that looks like what we need - what triples should be supported ?
i think this PR had that fix merged - not sure if some additional fix is required there |
8ea9971
to
26a6e3e
Compare
Signed-off-by: Ryan Northey <[email protected]>
26a6e3e
to
8556a4b
Compare
i tried setting i also tried setting im thinking that the most recent versions of |
Different idea: since the issue is a missing platform, you should be able to upgrade Bazel platform rules in WORKSPACE:
|
ive been a bit distracted with releases, ill circle back to this as soon as i have some time available |
Done in #399 -- thanks very much for starting this! |
No description provided.