-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jira-1883- Implementing Generate Report Functionality #37
Conversation
…nd added generic POST request method in L2.
Codecov ReportAttention: Patch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
…he generated file in desired location.
@parth-kulkarni1 has demo'd the functionality in a meeting with me. looks great! my suggestion was to add to the user docs so that people can see how to use this feature |
I added user docs now as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code and tested it on local machine. Works and generates the report in docx format. Python notebook also contains example code for this feature.
Jira-1883 - Implement Generate Report Functionality into Client Library - Minor
JIRA Ticket 1883
Checklist
Description
This PR contains the implementation of the Generate Report Functionality. An API call is made, and the bytes content is taken from the API response and written into a word file.
Notes for reviewer
This implementation required a newer addition of a generic
validated_post_request
method which makes a POST request and returns the raw response itself.There were some small changes made in the
write_file_helper
method to also incorporate logic for writing bytes content.No tests written as this is purely a Provena Web App functionality.