Skip to content

fix: URL to info swap #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: harmony-stg
Choose a base branch
from
Open

fix: URL to info swap #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9650862
fix: URL to info swap
mzfshark Mar 1, 2024
4d41272
update: change navbar UX
mzfshark Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"editor.formatOnSave": false,
"editor.inlineSuggest.enabled": true,
"editor.codeActionsOnSave": {
"source.fixAll": true
"source.fixAll": "explicit"
},
"files.eol": "\n",
"eslint.enable": true,
Expand Down
14 changes: 10 additions & 4 deletions src/components/NavBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,21 @@ export const PageTabs = () => {
)}
<Box display={{ sm: 'flex', lg: 'none', xxl: 'flex' }} width="full">
<MenuItem href="/pools" dataTestId="pool-nav-link" isActive={isPoolActive}>
<Trans>Positions</Trans>
<Trans>Pools</Trans>
</MenuItem>
</Box>
<MenuItem href="https://info.harmony.one/#/harmony/pools" external dataTestId="pool-nav-link">
<Trans>Pools</Trans>

<MenuItem href="https://info.swap.harmony.one/#/harmony/" external dataTestId="pool-nav-link">
<Trans>InfoSwap</Trans>
</MenuItem>
<MenuItem href="https://info.harmony.one/#/harmony/tokens" external dataTestId="pool-nav-link">

{/* Removed menu item

<MenuItem href="https://info.swap.harmony.one/#/harmony/tokens" external dataTestId="pool-nav-link">
<Trans>Tokens</Trans>
</MenuItem>
*/}

<Box marginY={{ sm: '4', md: 'unset' }}>
<MenuDropdown />
</Box>
Expand Down