Skip to content

Backport binary proto serialization/deserialization changes and enable protobuf Editions #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

dibenede
Copy link
Contributor

No description provided.

@dibenede dibenede requested a review from varomodt July 21, 2025 19:57
@dibenede dibenede force-pushed the editions branch 2 times, most recently from a3e197c to 8c50065 Compare July 21, 2025 20:39
@dibenede dibenede force-pushed the editions branch 3 times, most recently from ecea63c to 179001d Compare July 22, 2025 23:37
Copy link
Contributor

@varomodt varomodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, please squash these commits

This change backports our binary serialization/deserialization
code. The newer code includes several years worth of improvements that
improve the overall conformance findings. The improved state of things
allows us to enable protobuf edition 2023.

Other items:

- Add missing export annotation for BinaryReader.readStringRequireUtf8
- promote protobuf conformance testing client to main directory
@dibenede dibenede merged commit 4ce9069 into protocolbuffers:main Jul 23, 2025
4 checks passed
@dibenede dibenede deleted the editions branch July 23, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants