Skip to content

Conversation

@matteobettini
Copy link
Member

@matteobettini matteobettini commented Mar 27, 2025

Calling vmas.seed(0) won't affect the seeds (torch, numpy, python) outside the library.

VIce versa, calling torch.manual_seed(0) outside vmas won't affect the seed inside the library

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (06f29d4) to head (6e76e55).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vmas/simulator/environment/environment.py 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   87.09%   87.13%   +0.04%     
==========================================
  Files          93       93              
  Lines       10411    10462      +51     
==========================================
+ Hits         9067     9116      +49     
- Misses       1344     1346       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matteobettini matteobettini merged commit 4a5b53e into main Mar 29, 2025
4 checks passed
@matteobettini matteobettini deleted the local_seed branch March 29, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants