Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with mpl v3.9.2 (latest) #459

Closed
wants to merge 95 commits into from

Conversation

cvanelteren
Copy link

Continuation of #458 and #450. This PR makes it up-to-date with the latest mpl version.
It passes the generate unittests from #458, I will do some finalize testing since the colormaps are the major change in the last couple of mpl versions.

@cvanelteren
Copy link
Author

cvanelteren commented Jul 25, 2024

  • TODO fix docs
  • Note this makes use of the backwards compatibility for the colormaps. Over time these will be deprecated by mpl. I am still trying to figure out how @lukelbd uses the colormaps here, and how to adapt the code to mpl. For now everything seems to be running fine

@cvanelteren cvanelteren mentioned this pull request Aug 20, 2024
@huddao
Copy link

huddao commented Aug 27, 2024

cannot install:

$ pip install git+https://github.com/proplot-dev/proplot.git@refs/pull/459/head
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Collecting git+https://github.com/proplot-dev/proplot.git@refs/pull/459/head
  Cloning https://github.com/proplot-dev/proplot.git (to revision refs/pull/459/head) to /tmp/pip-req-build-0rm6thj_
  Running command git clone --quiet https://github.com/proplot-dev/proplot.git /tmp/pip-req-build-0rm6thj_
  WARNING: Did not find branch or tag 'refs/pull/459/head', assuming revision or ref.
  Running command git fetch -q https://github.com/proplot-dev/proplot.git refs/pull/459/head
  Running command git checkout -q f7524a24eef76f59b5d0fad56faac14e9fcf0846
  Resolved https://github.com/proplot-dev/proplot.git to commit f7524a24eef76f59b5d0fad56faac14e9fcf0846
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: importlib-metadata in /public/home/hzc/soft/anaconda3-2023/envs/geos-chem-3.11/lib/python3.11/site-packages (from proplot==0.9.5.post425) (8.4.0)
Requirement already satisfied: zipp>=0.5 in /public/home/hzc/soft/anaconda3-2023/envs/geos-chem-3.11/lib/python3.11/site-packages (from importlib-metadata->proplot==0.9.5.post425) (3.20.0)

@cvanelteren
Copy link
Author

cvanelteren commented Aug 27, 2024

@huddao huddao I don't see any errors?

@huddao
Copy link

huddao commented Aug 27, 2024

@cvanelteren The version is 'proplot==0.9.5.post425', I'm not sure this is the correct version.

@cvanelteren
Copy link
Author

The correct version should be tagged as v0.9.91. Try installing it from here:

pip install git+https://github.com/cvanelteren/[email protected]

@huddao
Copy link

huddao commented Aug 27, 2024

@cvanelteren Thanks!

@austin-hoover
Copy link

Working for me! Thank you cvanelteren.

@austin-hoover
Copy link

Any update on this? I'm posting analysis code for a paper and it would be great to reference the main proplot branch in the requirements.

@riley-brady
Copy link

Nothing that I've seen @austin-hoover. Still waiting on @lukelbd to come in and merge, as he is the only one with permissions. For now you will have to point to @cvanelteren's branch. You can always update your code repo linked to the paper at a later point and point back to a main release here.

@cvanelteren
Copy link
Author

Any movement on this @lukelbd?

@austin-hoover
Copy link

Also PyPI doesn't allow direct links to GitHub repos, so projects on PyPI can't list working proplot version as a dependency right now.

@cvanelteren
Copy link
Author

cvanelteren commented Nov 7, 2024

I wanted to address the current status of proplot's development. With the recent lack of movement on this project, there's a genuine concern about potentially losing our valuable contributors. To prevent this, I'm proposing we restructure the project under a more collaborative, organization-based framework that would:

  1. Facilitate continued development
  2. Decentralize the pull request process
  3. Enable broader community participation

Beginning in the new year, I'm prepared to take on a more active leadership role in this initiative. My plan includes forking the repository to maintain development momentum, but I'm committed to keeping communication channels open with @lukelbd and other stakeholders.

I'd like to extend an invitation to all interested contributors to join this effort. If you're passionate about proplot's future and want to be part of its continued development, please reach out to discuss how we can collaborate effectively.

Together, we can ensure proplot remains a vibrant and well-maintained project that serves its community's needs.

@riley-brady
Copy link

I wanted to address the current status of proplot's development. With the recent lack of movement on this project, there's a genuine concern about potentially losing our valuable contributors. To prevent this, I'm proposing we restructure the project under a more collaborative, organization-based framework that would:

  1. Facilitate continued development
  2. Decentralize the pull request process
  3. Enable broader community participation

Beginning in the new year, I'm prepared to take on a more active leadership role in this initiative. My plan includes forking the repository to maintain development momentum, but I'm committed to keeping communication channels open with @lukelbd and other stakeholders.

I'd like to extend an invitation to all interested contributors to join this effort. If you're passionate about proplot's future and want to be part of its continued development, please reach out to discuss how we can collaborate effectively.

Together, we can ensure proplot remains a vibrant and well-maintained project that serves its community's needs.

Please keep us posted when you fork out and launch the project. My job has severely limited the time I have to directly contribute, but I can continue with scoping as I did here. Might have some opportunities to contribute directly as well. Thanks @cvanelteren and enjoy your well-earned vacation!

@beckermr
Copy link

beckermr commented Nov 8, 2024

@cvanelteren count me in on helping with dev as I can and I'd like to be a part of the effort. Also, I am cross-referencing the issue currently open on more sustainable development (#452).

From the point of view of shipping a fork on conda-forge, it will be by far the easiest if the forked project gets a new name.

@cvanelteren
Copy link
Author

Yes I agree @beckermr -- I already have a logo for it ;-). I will be in touch in the new year!

@pratiman-91
Copy link
Contributor

@cvanelteren I am willing to help wherever I can. I like proplot, and it would be nice to see a continuous development along with the latest matplotlib.

@gepcel
Copy link

gepcel commented Dec 9, 2024

Any updates on this? Now matplolitb 3.9.3 is out. Would be nice to see continuous development along with the latest matplotlib.

@cvanelteren
Copy link
Author

See thread above

@gepcel
Copy link

gepcel commented Dec 12, 2024

See thread above

Thanks for your reply. I have followed this thread since the very beginning, and I'm eager to hear some updates on the forking repository and maintaining development. Maybe I'm not capable of helping, but I like this package.

Any way I'll just wait for the new year.

@jenchen95
Copy link

Thank you very much for your contribution, although I regret the single pull request review access, when reviewers are in the middle of a busy work schedule or vacation process, quality contributions like this can go unnoticed, which can wear down the enthusiasm for open source contributions.

@cvanelteren
Copy link
Author

Continue discussion here cvanelteren#1

@cvanelteren
Copy link
Author

@gepcel this commit is compatible with mpl 3.9.3 (just tested)
Development will continue here https://github.com/Ultraplot/ultraplot

Closing this issue for now and everyone is welcome on the forked repo

@cvanelteren
Copy link
Author

pip install ultraplot is now live! 🥳
Conda following soon 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.