Skip to content

fix: dont check bool dtype until after ndarray conversion#412

Closed
scottstanie wants to merge 2 commits into
proplot-dev:masterfrom
scottstanie:fix-imshow-bool-fix
Closed

fix: dont check bool dtype until after ndarray conversion#412
scottstanie wants to merge 2 commits into
proplot-dev:masterfrom
scottstanie:fix-imshow-bool-fix

Conversation

@scottstanie

Copy link
Copy Markdown
Contributor

This appears to fix #411

In [1]: import proplot as pplt
import numpy as np

In [2]: import numpy as np

In [3]: fig, ax = pplt.subplot()
   ...: ax.plot(np.arange(10))
Out[3]: <a list of 1 Line2D objects>

@syrte Feel free to check on this if you have other

@lukelbd

lukelbd commented Mar 26, 2023

Copy link
Copy Markdown
Collaborator

Sorry, awkward timing -- just submitted a fix myself (see issue thread). Appreciate the contribution though.

And thanks for the test. I am currently working on adding lots of unit tests to the CI workflow; will add your function to these.

@lukelbd lukelbd closed this Mar 26, 2023
@lukelbd lukelbd added the bug label Mar 26, 2023
@scottstanie

Copy link
Copy Markdown
Contributor Author

oh great, no problem! that timing was so exact that it confused me how my branch suddenly had merge conflicts haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: error with the latest dev version AttributeError: 'list' object has no attribute 'dtype'

2 participants