fix: dont check bool dtype until after ndarray conversion#412
Closed
scottstanie wants to merge 2 commits into
Closed
fix: dont check bool dtype until after ndarray conversion#412scottstanie wants to merge 2 commits into
scottstanie wants to merge 2 commits into
Conversation
Collaborator
|
Sorry, awkward timing -- just submitted a fix myself (see issue thread). Appreciate the contribution though. And thanks for the test. I am currently working on adding lots of unit tests to the CI workflow; will add your function to these. |
Contributor
Author
|
oh great, no problem! that timing was so exact that it confused me how my branch suddenly had merge conflicts haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to fix #411
@syrte Feel free to check on this if you have other