Add fwf_positions functionality and utilize vroom instead of readr#2
Open
jimbrig wants to merge 3 commits intoprontog:masterfrom
jimbrig:master
Open
Add fwf_positions functionality and utilize vroom instead of readr#2jimbrig wants to merge 3 commits intoprontog:masterfrom jimbrig:master
jimbrig wants to merge 3 commits intoprontog:masterfrom
jimbrig:master
Conversation
Owner
|
@jimbrig2011 thanks for PR! It looks good.
Again thanks for taking time to evaluate this package and for the PR. If you don't want to make any changes or disagree with my remarks, I will happily apply them myself. Best Regards, Panos |
Author
Owner
|
@jimbrig2011 take your time.There's no hurry. It's great to hear from you again! I though I lost my second verified user :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #1