-
Notifications
You must be signed in to change notification settings - Fork 9
[chore] tag releases automatically #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] tag releases automatically #18
Conversation
|
|
This comment was marked as abuse.
This comment was marked as abuse.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughGitHub Actions publish workflow updated: triggers set to push on Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7f3e617 to
ad3ada1
Compare
CNSeniorious000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mdaniels5757! Just a few nits.
ad3ada1 to
c860319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
10-25: Minor edge case with shallow git history.Line 19 uses
git diff --quiet HEAD~1 HEAD, which will fail if HEAD~1 doesn't exist (e.g., first commit or shallow clone). Whilefetch-depth: 2mitigates this in normal circumstances, manualworkflow_dispatchtriggers on limited history could encounter this. Consider adding a guard, e.g.,git rev-parse HEAD~1 >/dev/null 2>&1 && git diff --quiet HEAD~1 HEAD || echo "CHANGED=true".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/publish.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: test (windows-latest, pypy3.11)
- GitHub Check: test (macos-latest, pypy3.10)
- GitHub Check: test (windows-latest, 3.11)
- GitHub Check: test (macos-latest, pypy3.11)
- GitHub Check: test (macos-latest, 3.7)
- GitHub Check: Sourcery review
🔇 Additional comments (2)
.github/workflows/publish.yml (2)
3-7: Trigger configuration looks good.Listening for pushes to
mainandworkflow_dispatchprovides both automatic and manual release control, which aligns with the PR objectives.
44-61: Excellent resolution of past concerns.The publish job now correctly:
- Removes
continue-on-errorso failed PyPI publishes halt the workflow (preventing orphaned releases)- Uses the defined
VERSIONvariable instead of undefinedtag(line 59)- Extracts version via grep instead of Python (line 50), matching the PDM backend convention
- Includes
dist/*as release assets (line 61)- Restricts PyPI publishing to the official repository (line 45)
All prior review feedback has been successfully incorporated.
|
I will merge it later. |
This makes things easier for packagers :).
I did assume that you only want to publish by default when pushing to the default branch (now
main). You can still trigger publishing from another branch by running the workflow manually. If I'm wrong, let me know and I'd be happy to change it back.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.