Skip to content

Conversation

khunafin
Copy link

No description provided.

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

Signed-off-by: Nail Khunafin <[email protected]>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to fix the Go linter errors.

Signed-off-by: Nail Khunafin <[email protected]>
@tjhop
Copy link
Contributor

tjhop commented Sep 23, 2023

I stumbled across this PR while investigating for #565. If the approach used in #569 is accepted, it would seem like a similar approach may be needed here as well

@PiotrProkop
Copy link

@khunafin are you planning to update this PR? If not I am willing to help with this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants