Add the GOOS to CI test #1787
Open
Add the GOOS to CI test #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
kakkoyun
requested changes
Apr 10, 2025
|
When we are at it maybe we should add GOARCH as well. Now that GitHub actions have the arm64 machines. |
|
I also worked on this ticket 2 weeks ago but I didn't fix all: diff link. I managed to conditionally enable CGO based on need, but I'm still running into test failures on Windows. I'd really appreciate any pointers on how to get those passing. Since you also opened a PR on this topic, maybe you’ll find some ideas or inspiration from my approach too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the KubeCon ContribFest 👋
This PR added GOOS as variable to the go test CI
Fix #1761
Please check @ArthurSens