[mobile-price-classification] Add dataset downloading and uploading to s3 in the notebook #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korel
force-pushed
the
pipelines/mobile-price-classification/auto-download-training-data
branch
from
1366848 to
a644963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I'm testing if pipelines are working, I go to this example but I then have to go to kaggle (again and again as I delete the dataset after some time from laptop :D). I was suprised to see kaggle does not need login to use its python API. So, I put the steps of downloading the dataset and pushing to minio in the notebook. It only requires user to set their bucket. It then gets the minio credentials from environment.
Note: Technically,
s3fs.S3FileSystem(anon=False)should make s3fs use Environment values, however it did not work for for a reason, so I gave all the values explicitly.