Implement authorization #498
Merged
+792
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It superseds `replicate_after_connect`. By default we just verify compatibility between client and server, but it's customizable via `RepliconSharedPlugin::auth_method`. In the Tic-Tac-Toe example, I switched to deterministic sorting, which is more efficient because I also used it in the doc example for authorization.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 81.64% 82.24% +0.59%
==========================================
Files 52 53 +1
Lines 3019 3104 +85
==========================================
+ Hits 2465 2553 +88
+ Misses 554 551 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was
linked to
issues
May 29, 2025
Shatur
added a commit
to projectharmonia/bevy_replicon_renet
that referenced
this pull request
May 31, 2025
- React on `DisconnectRequest` event. Relevant PR: projectharmonia/bevy_replicon#491 - Process received data on disconnect. Relevant PR: projectharmonia/bevy_replicon#494 - Update examples. Relevant PRs: projectharmonia/bevy_replicon#498 projectharmonia/bevy_replicon#479 - Update tests. - Move server stopping into a separate test. Relevant PR: projectharmonia/bevy_replicon#494 - Add `finish` calls. Required to initialize channels. Relevant PR: projectharmonia/bevy_replicon#488 - Test `DisconnectRequest`. Relevant PR: projectharmonia/bevy_replicon#491 - Remove uses of the word "Dummy". Relevant PR: projectharmonia/bevy_replicon#486
Shatur
added a commit
to projectharmonia/bevy_replicon_renet
that referenced
this pull request
May 31, 2025
- React on `DisconnectRequest` event. Relevant PR: projectharmonia/bevy_replicon#491 - Process received data on disconnect. Relevant PR: projectharmonia/bevy_replicon#494 - Update examples. Relevant PRs: projectharmonia/bevy_replicon#498 projectharmonia/bevy_replicon#479 - Update tests. - Move server stopping into a separate test. Relevant PR: projectharmonia/bevy_replicon#494 - Add `finish` calls. Required to initialize channels. Relevant PR: projectharmonia/bevy_replicon#488 - Test `DisconnectRequest`. Relevant PR: projectharmonia/bevy_replicon#491 - Remove uses of the word "Dummy". Relevant PR: projectharmonia/bevy_replicon#486
UkoeHB
requested changes
Jun 2, 2025
src/server.rs
Outdated
| AuthMethod::ProtocolCheck => { | ||
| app.add_observer(check_protocol); | ||
| } | ||
| AuthMethod::Disabled => { |
There was a problem hiding this comment.
Suggested change
| AuthMethod::Disabled => { | |
| AuthMethod::None => { |
This is more semantically accurate. Setting the auth method doesn't 'disable' anything.
Comment on lines
440
to
442
| self.world_mut() | ||
| .resource_mut::<ProtocolHasher>() | ||
| .add_replication_rule::<R>(); |
UkoeHB
approved these changes
Jun 2, 2025
Shatur
added a commit
to projectharmonia/bevy_replicon_renet
that referenced
this pull request
Jun 2, 2025
- React on `DisconnectRequest` event. Relevant PR: projectharmonia/bevy_replicon#491 - Process received data on disconnect. Relevant PR: projectharmonia/bevy_replicon#494 - Update examples. Relevant PRs: projectharmonia/bevy_replicon#498 projectharmonia/bevy_replicon#479 - Update tests. - Move server stopping into a separate test. Relevant PR: projectharmonia/bevy_replicon#494 - Add `finish` calls. Required to initialize channels. Relevant PR: projectharmonia/bevy_replicon#488 - Test `DisconnectRequest`. Relevant PR: projectharmonia/bevy_replicon#491 - Remove uses of the word "Dummy". Relevant PR: projectharmonia/bevy_replicon#486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It superseds
replicate_after_connect. By default we just verify compatibility between client and server, but it's customizable viaRepliconSharedPlugin::auth_method.